Added the ability to map gamepad buttons to hotkeys.

[skidau]

To set up a mix of keyboard and gamepad shortcuts, follow these steps:

1. In the main hotkey config, change the Device to Keyboard
2. Right click the hotkey button that you wish to map to your gamepad
3. In the window that pops up, change the Device to your gamepad
4. Press the Clear button
5. Press Detect and press the button on your gamepad that you want to map
6. Press Select
7. Press OK

To map a combo hotkey, e.g. Shift F5, follow these steps

1. Follow steps 1-4 above
2. Press Detect and the modifier button (e.g. Shift)
3. Press Select
4. Press Detect and the button which isn't the modifier (e.g. F5)
5. Press the "& AND" button
6. Press OK

[Kodiack]

It looks like binding things to controller work properly after preliminary testing, although it also appears that KB/mouse and gamepad binds are unable to be utilised simultaneously. For example, if I set the frame unlimiter to something on a controller, it will work, although I will then be unable to use basic keyboard shortcuts like alt+enter or escape. The binds only work on the "active" input device. I'm unsure if this is an inherent limitation or not.

Regardless, it's great to see some progress on this front, so kudos for that, skidau!

[skidau]

That is a feature of Dolphin's controller interface. To set up a mix of keyboard and gamepad shortcuts, follow the steps in the description.

[Kodiack]

That seems to work okay for simultaneous binding! I'm running into an issue when binding stuff where it will frequently run into a syntax error, though, at which point it will not allow me to apply the bindings and I need to clear them to even close the window. I'll test a bit and see if I can find some consistency in that behaviour.

EDIT: Ah, I see what was going on. It was a good ol' PEBKAC error. The menu just uses some basic logic commands, and I think I accidentally hit "| OR" to start a string instead of "Select". Once I understood how the control method actually worked, it seems to be just fine.

[skidau]

This should fix Issues 2986 and 7652.

[CarlKenner]

Cegli already implemented something like this in the Dolphin VR fork.

[lioncash]

ok

[skidau]

@dolphin-emu-bot rebuild

[Parlane]

@dolphin-emu-bot rebuild

[Parlane]

@dolphin-emu-bot rebuild

[ROMaster2]

Bad news. It seems the controller configs crash the whole program when you try to open them. 5400 doesn't crash but 5402 does crash as a result of this pull. Hopefully this can be resolved.

[skidau]

@ROMaster2 what operating system are you using?

[ROMaster2]

Yeah I probably should have mentioned that. Windows 7 Ultimate 64-bit SP1

I can record something really quickly with OBS if needed.

[skidau]

@ROMaster2 not sure how I missed that bug. I have created a fix for it in #2010 if you could test it for me?

[ROMaster2]

Oops, sorry for the delay. Yeah it still crashes

Here's a video which I'll delete shortly: https://www.dropbox.com/s/3j3v0kdzrt846pm/stream_temp.mp4?dl=0

[skidau]

@ROMaster2, thanks - I have update the build to fix the crash on the Wiimote configuration too. Let me know if you spot any other bugs.

[cegli2]

@skidau Doing a little more testing, I'm having problems with getting the free look to work consistently. I've tried two separate computers, and tried deleting my old .ini files. It seems like it only detects about 5% of my button presses or something. The other hotkeys seem to be working, so I'm not sure what the deal is. Let me know if you see the same behavior, or if it's only me. Looking in the debugger it looks like it's constantly going through "HotkeyManagerEmu::IsPressed" as well, even when I'm not hitting any buttons? Other hotkeys (save states, frame limiter, etc) seem to be working well.

[psennermann]

On my system this merge caused a general game speed slowdown of about 4%...

[Kodiack]

There seems to be another possible regression here: When Escape is used as the hotkey to exit a game, it will do just that even when you mean for it to close a menu. For example, set escape as this hotkey if it's not already, open a game, and then open a menu (like the graphics menu). Then, try to close the menu with escape. The menu will close, but so will the game unless "Confirm on Stop" behaviour is set.