Revert "Remove an unnecessary wx translation underscore macro from PHackSettings." #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackSettings." This reverts commit 110f603.
|
If the plan is to remove this entire feature anyway, I see no point in this revert. |
|
The discussion of the original commit and the removal of the whole feature are unrelated. The merge was wrong and it should be reverted, then we may start talking about removing the feature. |
|
Optimise ffs. |
neobrain
added a commit
that referenced
this pull request
Mar 24, 2014
Revert "Remove an unnecessary wx translation underscore macro from PHackSettings."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reverts commit 110f603.