Add UI Support for up to 8x Internal Resolutions #2024
Conversation
|
Who the hell has monitors that big? EDIT: |
|
Higher IRs also act as anti-aliasing. |
|
Not with the current downscaling algorithm, they don't. https://code.google.com/p/dolphin-emu/issues/detail?id=7746 |
|
6x IR matches the width of a 4K display, so people with high end machines will see some use of this. |
|
Does the "increase IR" hotkey still works fine? |
|
I will say just one thing, i am pretty certain there will be a lot of posts in the forums about slow speed with the emulator while having 8x IR... using their laptop... There are a lot of people that will just use the highest value they can find and expect everything to run smooth afterwards. For example some don't even need the 4x value and still they use it simply because it is the highest choice and it is there to select it. |
|
Thanks for adding this. imo this should satisfy Issue 7711 but I don't know if others would agree with that. |
|
This is getting quite ridiculous. Other than that, I'd suggest just merging those resolutions into a "custom" item, and have the value configurable in discrete steps as a wxSlider. |
|
To everyone: For screenshots, videos, and other features in Dolphin; having this available would be nice. |
|
The only problem I see with this is accidentally clicking a crazy high IR On Mon, Feb 9, 2015 at 7:17 PM, JMC47 notifications@github.com wrote:
|
|
Could there be suggestions depending on the monitor apart from just displaying the resolution? Also make auto integral the suggested value used. |
|
|
|
I don't like the idea to make anything beside 1x Native as default. |
|
I think auto is already default. Also + 1 for naming them. Maybe adding a description that higher IRs can be extremely slow on weaker (or even strong) hardware. |
| _("2.5x Native (1600x1320)"), _("3x Native (1920x1584)"), _("4x Native (2560x2112)"), _("Custom") }; | ||
| _("1x Native (640x528)"), _("1.5x Native (960x792)"), _("2x Native (1280x1056) for 720p"), _("2.5x Native (1600x1320)"), | ||
| _("3x Native (1920x1584) for 1080p"), _("4x Native (2560x2112) for 1440p"), _("5x Native (3200x2640)"), | ||
| _("6x Native (3840x3168) for 4K"), _("7x Native (4480x3696)"), _("8x Native (5120x4224)"), _("Custom") }; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Can you also update the texts that display when changing settings, where it says which IR is currently used, which efb type, fog etc. : And pretty please with support for custom resolutions, and not just the ones you add to the UI? |
RisingFog
force-pushed
the
irgui
branch
2 times, most recently
from
3bba140
to
d0b57b9
Compare
|
@dolphin-emu-bot rebuild (test, please ignore) |
|
bump |
|
Partially a question and partially a suggestion but what exactly is the purpose of the 1.5x and 2.5x settings? I was under the impression that integer scaling was preferred for higher IRs. Would there be any harm in removing those to help clean up the list? |
|
@pringo 1.5x or 2.5x is better than 1x or 2x for those with worse computers. Yes, it's not optimal, but it's better. |
|
I might be alone on this but if that's the only reason I'd support removing those options. 1.5x and 2.5x aren't going to provide major benefits over 1x and 2x and thanks to all the optimization work that's been done those users can probably get fullspeed now with 2x or 3x compared to the 4.0.2 release. I think removing these half step options would help clean up the interface. |
|
@ADormant not really in the scope of the PR tbh |
|
@ADormant create a new issue for it. I've been meaning to do it (as I have the same issue) but I hadn't seen confirmation from someone else experiencing it until now. :D |
|
Is there anything that is still preventing this pull request from being merged |
|
@ADormant You posted something similar like this yesterday. You don't need to keep bumping it; people likely saw the first message. |
|
@RisingFog I agree with @neobrain that limiting resolutions based on a user's screen resolution would be the best option. Monitor resolutions increase all the time. |
|
Well, can't we just leave as is? It'd be user's own responsibility for picking excessive resolutions. |
|
... for reference, I was just kidding, referring back to my initial comment in this thread. It's a terrible idea, really, which I thought was obvious enough. |
|
Can we at least put in a custom IR option w/ an aspect ratio lock? That would probably be the cleanest way to deal with large IRs whilst still allowing for fullscreen with upscaling. |
|
I agree with @neobrain (but i guess someone else could merge this if/when it becomes merge-able through github's nice merge button...). No clue how these tiny things generate so many comments. |
|
Adding one more +1 to this PR. I was messing around with triple monitor Nvidia surround with 3x 1440p monitors. The 4x IR option wasn't enough to capably fill all of that space, but with the auto option, my GTX 970 was unable to maintain consistently full speed. 8x would still not be enough for the three monitors, but it would probably be good enough. |
| res_text = "8x"; | ||
| break; | ||
| default: | ||
| res_text = (g_ActiveConfig.iEFBScale - 3) + "x"; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Bump. |
RisingFog
force-pushed
the
irgui
branch
11 times, most recently
from
f06ec86
to
eeb6ec4
Compare
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| #include <cinttypes> | |||
| #include <cmath> | |||
| #include <sstream> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Add UI Support for up to 8x Internal Resolutions
|
@karasuhebi, the reason that it's sharper is because of Wind Waker's "depth of field" effect. Said depth of field effect can be fully disabled with a projection hack via an INI setting, which will heavily negate the benefits of increasing IR beyond your monitor's native resolution. Anyone looking for better anti-aliasing would be much better served using SSAA if their IR already matches their monitor's resolution. SSAA does actual filtering while downsampling, whereas increasing IR is a bit more naive. You'll get a "sharper" image, but you're still prone to realise aliasing. Here's a link to some projection hack INI settings that will remove the DOF in Wind Waker; give 'em a shot and you'll see that extra IR isn't nearly as beneficial as it may first appear: I also had a patch over a year ago that allowed up to 6xIR. I rather liked neobrain's stance with that. https://forums.dolphin-emu.org/Thread-patch-5x-3200x2640-and-6x-3840x3168-native-ir Things really are starting to look a bit ridiculous. I think that a slider for IR may be a good idea. There could be an exponential slider, much like what Fiora implemented for overclocking the emulated CPU. Perhaps it would even be possible to add in a text box next to it, where people could punch in a specific IR and have the slider snap to that value. |
|
+1 to @Kodiack 's suggestion for a slider and box, but to also have a vertical box. |
ghost
mentioned this pull request
Add UI Support for up to 8x Internal Resolutions
Adds new options from 5x up to 8x for Internal Resolutions.