Fix OpArg::WriteRex with 8-bit memory operand. #210
Merged
+17
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously he function was misbehaving because of a missing check for whether an 8-bit operand was a register operand; it would therefore emit unnecessary REX prefixes, incorrectly assert on 32-bit targets, and could potentially emit wrong code in rare cases (like a memory to register operation involving AH.) Also, some cleanup while I was in the area to make the function easier to read.
|
LGTM (and added to the trusted devs list). |
|
@magumagu you might find https://github.com/shuffle2/dolphin/commits/ugly-hacks interesting if you are attempting to fix 32bit jit issues. |
|
@dolphin-emu-bot rebuild |
delroth
added a commit
that referenced
this pull request
Mar 26, 2014
Fix OpArg::WriteRex with 8-bit memory operand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Previously the function was misbehaving because it would treat an 8-bit memory operand as if it referred to an 8-bit register. It would therefore emit unnecessary REX prefixes, incorrectly assert on 32-bit targets, and
could potentially emit wrong code in rare cases.
Also, some cleanup while I was in the area to make the function easier to read.