Win32 jit fixes #211
Merged
Win32 jit fixes #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Win32, the stack isn't aligned, so aligned stores will cause crashes.
(The numbers need to be consistent with the actual usage, or else the stack gets corrupted.)
I have no idea what the person who added RegistersInUse() was thinking, but not correctly saving registers is an easy way to end up with crashes.
|
Can confirm this fixes the segfaults I have had. Very good! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Misc fixes to get the JIT working again on win32.
The changes to Source/Core/Common/x64ABI.cpp were taken from shuffle2's ugly-hacks branch, but I think they're both suitable for master.