Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Zelda ucode cleanup #214
Fixes the Zelda Ucode so it doesn't directly interact with Dolphin's audio output. Inspired by Issue 7111.
I haven't tested this on anything other than Twilight Princess; I wouldn't be surprised if this breaks other games. And I haven't touched the mail handling code, so it's still a complete mess.
Super Mario Galaxy 1 and 2 no longer freeze on Grand Stars, Wind Waker no longer freezes under slowdown. Super Mario Galaxy 1 and 2 both have music that works forever (at least in my testing, it never stopped.)
Wind Waker's Magic Meter, SMG1/2's volume issues, and SMS's pause sound being weird all are unaffected so far.
Regardless, the big issues seem to be fixed, amazing!
Edit, few more notes
Mario Kart Double Dash no longer loses music, but the volume levels of certain sounds vs music is still way off.
Pikmin 1 no longer freezes if you spam savestates around the day/night transitions (was able to reproduce in master, not in this pull request)
Other notable thing I found is that Zelda ucode is no longer asynchronous, so it now acts like the rest of HLE.