Audio handling cleanup v2 #220
Merged
+81
−232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, nice catch |
| @@ -143,7 +118,9 @@ bool DSPLLE::Initialize(void *hWnd, bool bWii, bool bDSPThread) | |||
| irom_file = File::GetSysDirectory() + GC_SYS_DIR DIR_SEP DSP_IROM; | |||
| if (!File::Exists(coef_file)) | |||
| coef_file = File::GetSysDirectory() + GC_SYS_DIR DIR_SEP DSP_COEF; | |||
| if (!DSPCore_Init(irom_file, coef_file, AudioCommon::UseJIT())) | |||
|
|
|||
| bool UseJIT = SConfig::GetInstance().m_DSPEnableJIT; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@magumagu Just some helpful advice, but to rewind to commits you previously made to do changes, just use Just saying in case you didn't know :) |
This is good for a couple of reasons: one, it gets rid of duplicated code, and two, DSP emulation shouldn't need to interact with audio in the first place.
|
fixed my audio issues with brawl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Resubmitting previous request. (I'm still getting used to using git for this sort of workflow.)