D3DBackend: Don't recompute ID3D11InputLayout for different shaders. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -130,16 +140,20 @@ void D3DVertexFormat::SetupVertexPointers() | |||
| if (m_vs_bytecode != DX11::VertexShaderCache::GetActiveShaderBytecode()) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
magumagu
changed the title
|
Redid the fix: we don't actually need the map. We can just use the same ID3D11InputLayout for each shader. (CreateInputLayout only checks the signature, and that should be the same for every shader using the same vertex format.) |
|
@neobrain could you review this? |
| // CreateInputLayout requires a shader input, but it only looks at the | ||
| // signature of the shader, so we don't need to recompute it if the shader | ||
| // changes. | ||
| auto vs_bytecode = DX11::VertexShaderCache::GetActiveShaderBytecode(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@magumagu Did you check if the d3d11 debug runtime is okay with this change? |
CreateInputLayout requires a shader as an input, but it only cares about the signature; we don't need to recompute it for different shaders with the same inputs.
|
Updated patch changes the use of auto. Debug runtime seems fine with the change. |
neobrain
added a commit
that referenced
this pull request
Apr 11, 2014
D3DBackend: Don't recompute ID3D11InputLayout for different shaders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Rebuilding the layout isn't free, so cache it instead. My measurements show approximately a 5% performance improvement on a fifoplayer testcase on an Intel HD4000.
I'm not very familiar with the D3D backend, so I'm not sure if this fix is correct, or if there's a better approach.