New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a 251 block Memory card for games that do not work with larger cards. Fixes Issue 6753 #226
Conversation
|
@dolphin-emu-bot rebuild |
|
|
||
| [Core] | ||
| # Values set here will override the main dolphin settings. | ||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Other than that one comment, LGTM. While you're at it, maybe add a link to the Nintendo page in a comment in the INI file? |
|
Please take care to phrase the PR title properly in the future. It's written in merge commit messages automatically, and correcting the wording takes extra time on the merger's side. |
| // WTA Tour Tennis GWTEA4 GWTJA4 GWTPA4 | ||
| // Disney Sports : Skate Boarding GDXEA4 GDXPA4 GDXJA4 | ||
| // Disney Sports : Soccer GDKEA4 | ||
| // Use a smaller memorycard for these games |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Fixed the issues mentioned, sorry about the title, I'm new to github is it preferred to squash the new commits and rewrite the originals? |
|
Until all comments have been addressed, we prefer to add new commits on top of everything. Once all issues have been corrected, the corrections should be squashed into the original commits indeed (I guess that since no one else commented, you can squash now). |
Use a 251 block Memory card for games that do not work with larger cards. Fixes Issue 6753
|
Adds trailing whitespace to EXI_DeviceMemoryCard.cpp and causes the linter to be angry. |
|
it seems like a trivial change for a PR, but should I fix that in a new PR? I made these commits before learning of the new buildbot features, |
|
This is already merged; it's too late to add any more changes here. Just make a new PR. |
issue 6753 on tracker
A handful (4) of games fail using large memcards, as documented here
This branch automatically uses a memcard 251 for these games