Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a 251 block Memory card for games that do not work with larger cards. Fixes Issue 6753 #226

Merged
merged 2 commits into from Apr 3, 2014

Conversation

LPFaint99
Copy link
Contributor

issue 6753 on tracker
A handful (4) of games fail using large memcards, as documented here
This branch automatically uses a memcard 251 for these games

@Parlane
Copy link
Member

Parlane commented Mar 29, 2014

@dolphin-emu-bot rebuild


[Core]
# Values set here will override the main dolphin settings.

This comment was marked as off-topic.

@delroth
Copy link
Member

delroth commented Mar 29, 2014

Other than that one comment, LGTM. While you're at it, maybe add a link to the Nintendo page in a comment in the INI file?

@neobrain
Copy link
Member

Please take care to phrase the PR title properly in the future. It's written in merge commit messages automatically, and correcting the wording takes extra time on the merger's side.

// WTA Tour Tennis GWTEA4 GWTJA4 GWTPA4
// Disney Sports : Skate Boarding GDXEA4 GDXPA4 GDXJA4
// Disney Sports : Soccer GDKEA4
// Use a smaller memorycard for these games

This comment was marked as off-topic.

This comment was marked as off-topic.

@LPFaint99 LPFaint99 changed the title Use Memcard 251 for buggy games Issue6753 Use a 251 block Memory card for games that do not work with larger cards. Fixes Issue 6753 Mar 29, 2014
@LPFaint99
Copy link
Contributor Author

Fixed the issues mentioned, sorry about the title, I'm new to github

is it preferred to squash the new commits and rewrite the originals?

@neobrain
Copy link
Member

Until all comments have been addressed, we prefer to add new commits on top of everything. Once all issues have been corrected, the corrections should be squashed into the original commits indeed (I guess that since no one else commented, you can squash now).

delroth added a commit that referenced this pull request Apr 3, 2014
Use a 251 block Memory card for games that do not work with larger cards. Fixes Issue 6753
@delroth delroth merged commit c68be42 into dolphin-emu:master Apr 3, 2014
@Sonicadvance1
Copy link
Contributor

Adds trailing whitespace to EXI_DeviceMemoryCard.cpp and causes the linter to be angry.

@LPFaint99
Copy link
Contributor Author

it seems like a trivial change for a PR, but should I fix that in a new PR? I made these commits before learning of the new buildbot features,

@magumagu
Copy link
Contributor

magumagu commented Apr 4, 2014

This is already merged; it's too late to add any more changes here. Just make a new PR.

@LPFaint99 LPFaint99 deleted the Issue6753 branch April 12, 2014 19:21
Joern-P pushed a commit to Joern-P/dolphin that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants