Fix FIFO Player dialog assertion failures (aka work around wx's inability to handle size_t correctly). #229
+41
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of them use std::min and std::max, but this header wasn't included.
These are not needed anymore since wx 3.0. Also some minor formatting stuff.
|
One of these days I hope WX dies in a fire. |
delroth
added a commit
that referenced
this pull request
Mar 29, 2014
Fix FIFO Player dialog assertion failures (aka work around wx's inability to handle size_t correctly).
Joern-P
pushed a commit
to Joern-P/dolphin
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
So
udoesn't work directly, and neither doeslu. Withz[s,u,x]you get the awesome ability to crash the emulator without any assertion warnings whatsoever. So to compromise, we just cast to u32.