Larger cleanup to input-related source files (this time using unique_ptr). #23
+640
−791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erators that litter this section of the codebase. Also clean up a little bit of the comments that describe the interface classes.
…lass. Allows for the automatic handling of resource deallocation.
Changes a bunch of for+iterator loops into foreach loops.
Also cleaned up WiimoteEmu.h as well.
|
@BhaaLseN |
|
Ok, nvm then :) |
|
@BhaaLseN Actually, I'm not so sure. When I replied to your comment, I thought it was a general response, not a specific line comment :x. My bad. I think the current code in the initializer list is correct, but I'm open to being corrected. If anyone can clarify if it's necessary, that would be awesome. |
|
std::move is only needed when create a unique_ptr from another unique_ptr (and it will invalidate the previous unique_ptr - there can be only one unique_ptr pointing to an object). In this case it should be ok since the pointer is passed directly. Also, LGTM. |
|
@delroth Thanks for the clarification :) |
delroth
added a commit
that referenced
this pull request
Feb 2, 2014
Larger cleanup to input-related source files (this time using unique_ptr).
ghost
mentioned this pull request
rapito
pushed a commit
to project-lylat/dolphin
that referenced
this pull request
Jun 16, 2022
Beta Version Changes from LittleCoaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I took delroth's suggestion of using unique_ptr as well. However this required changes outside of InputComment to be done, and thus warranted it's own new branch (the previous one was called "small-inputcommon-cleanup" which would be inaccurate with the new changes)
This is open at the same time as PR #17 in case this one proves to be too messy (by opinion of course), then this one can be dropped and PR #17 can be used instead.
Anyway, feel free to point out anything that seems weird.