Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSPHLE Zelda cleanups #233

merged 2 commits into from Mar 30, 2014


2 participants
Copy link

delroth commented Mar 30, 2014

Rename variables to match our coding style, and change dynamic buffers to static buffers now that we use synchronous audio.

s32* m_LeftBuffer;
s32* m_RightBuffer;
s32 m_voice_buffer[5 * 32];
s16 m_resample_buffer[5 * 32];

This comment has been minimized.

Copy link

magumagu Mar 30, 2014


Are you sure this is enough space? I'm pretty sure at least the resample buffer requires a larger buffer than that.

(Also, m_left_buffer and m_right_buffer are only used from one function, so might as well make them locals.)

This comment has been minimized.

Copy link

delroth Mar 30, 2014

Author Member

No, I'm not :) I'll just revert this change - I'm planning to completely rewrite everything in ZeldaVoice/ZeldaSynth anyway.

delroth added a commit that referenced this pull request Mar 30, 2014

@delroth delroth merged commit bad1094 into dolphin-emu:master Mar 30, 2014

1 check passed

default Build succeeded on the Buildbot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.