Netplay: don’t show traversal server/port options (INI config only) #2349
Conversation
| IniFile inifile; | ||
| const std::string dolphin_ini = File::GetUserPath(D_CONFIG_IDX) + "Dolphin.ini"; | ||
| inifile.Load(dolphin_ini); | ||
| IniFile::Section& netplay_section = *inifile.GetOrCreateSection("NetPlay"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mathieui
force-pushed
the
remove-traversal-options-ui
branch
from
9b76602
to
c452e72
Compare
|
I have a separate patch in the works that does this plus some other UI changes, but this works, I guess. |
|
I think people who used the old version and had it save the blank server/port fields to their config won't see the new default. Haven't tested. Am I wrong? |
|
@comex That's right, I was thinking about it, and I from quick testing it appears to be the case |
|
I agree with this change, its silly how many people ask how to fix there netplay when they have accidentaly deleted the text, my other suggestion would be having a drop down box with a list a servers, this would allow for no confusion + the ability for custom servers for those websites which need them. |
|
This new commit makes it work if the option is empty or only contains spaces, but I'm not sure how to handle people who filled this entry incorrectly while they could edit it from the UI |
|
The menus kind of look a bit empty now, maybe move nickname menu to the right with the box justified to the right? http://i.imgur.com/iYDNtUV.png (crappy paint job) As for the problem with people who have incorrectly edited it, maybe make a default button, where it will reset it, and then add a tip to the netplay options about if it cant connect to try defaulting the server. |
…ult" button Clicking it will set the config file back to stun.dolphin-emu.org with port 6262.
Netplay: don’t show traversal server/port options (INI config only)
It's confusing for users, and websites or people willing to set up one can provide steps to edit config files, or pre-made config files.