Add dsp rom hashes to movie header. #248
Conversation
Also fix a random typo.
| @@ -74,7 +74,7 @@ static bool LoadRom(const std::string& fname, int size_in_words, u16 *rom) | |||
| return false; | |||
| } | |||
|
|
|||
| // Returns false iff the hash fails and the user hits "Yes" | |||
| // Returns false if the hash fails and the user hits "Yes" | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM |
|
@dolphin-emu-bot rebuild |
|
This PR grows old! ...poking @RachelBryk and other interested parties. |
|
What did we decide to do/not do for this? |
|
After a short discussion with @delroth , it seems that we indeed do want to have something like this. I'm a bit concerned about two issues though: |
|
It doesn't do anything if the hashes mismatch, the idea is just to have the information available, so it can be read with another tool made to read the dtm file. It isn't a critical error, so i'm not sure if it is necessary to alert the user at all. It can cause desyncs though, so if a movie doesn't sync, it's useful to know which rom was used, in case that is the reason. I don't think this is confusing at all, because tasers are not typical users, and would be accustomed to using a hex editor to read the file anyway. The same thing is done with video backend, where it's saved to the header, but never read, because in most cases it doesn't affect sync (but it can in rare cases so it's useful to have the information available). |
|
Sounds good then. @dolphin-emu-bot rebuild |
Add DSP rom hashes to movie header.
Also fix a random typo.