[rebased] Compare timebase of netplay users to detect desyncs. #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| packet >> x; | ||
| packet >> y; | ||
| packet >> frame; | ||
| s_timebase[frame].emplace_back(x | ((u64)y >> 32), player.pid); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
comex
force-pushed
the
netplay-timebase-rb
branch
2 times, most recently
from
edd3d9c
to
230d29b
Compare
comex
changed the title
comex
force-pushed
the
netplay-timebase-rb
branch
from
230d29b
to
9aaff45
Compare
|
Okay, should actually work now. |
Note - I removed a SleepCurrentThread(1) the patch added which seemed to be unrelated to the actual job at hand. If there was a real need for it (which sounds like it would be an enet-related bug - enet_host_service is supposed to *sleep*), that needs to be dealt with...
comex
force-pushed
the
netplay-timebase-rb
branch
from
9aaff45
to
efb4374
Compare
| @@ -129,6 +130,13 @@ void SetIsFramelimiterTempDisabled(bool disable) | |||
| std::string GetStateFileName() { return s_state_filename; } | |||
| void SetStateFileName(const std::string& val) { s_state_filename = val; } | |||
|
|
|||
| void FrameUpdateOnCPUThread() | |||
| { | |||
| if (!IsCPUThread()) abort(); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
comex
force-pushed
the
netplay-timebase-rb
branch
from
efb4374
to
9c63b78
Compare
|
In a quick test this is absolutely amazing. |
|
JMC47: Lioncash, review 2517 ;D |
comex
added a commit
that referenced
this pull request
Jun 8, 2015
[rebased] Compare timebase of netplay users to detect desyncs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Based on #2178. Haven't done much more than rebase and compile check yet, since I'm about to go to sleep, but in the spirit of getting things done...