Remove dumb CodeBlock duplication in the emitters. #253
+111
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
| void ClearCodeSpace() | ||
| { | ||
| // x86/64: 0xCC = breakpoint | ||
| memset(region, 0xCC, region_size); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
All comments addressed, when changing the CodeBlock class to NonCopyable, I had to drop it from the VertexLoader and DSPEmitter since they inherit from the CodeBlock class. |
| // You get memory management for free, plus, you can use all emitter functions without | ||
| // having to prefix them with gen-> or something similar. | ||
| // Example implementation: | ||
| // class JIT : public CodeBlock<ARMXEmitter> {} |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Comments have been addressed |
| template<class T> class CodeBlock : public T, NonCopyable | ||
| { | ||
| private: | ||
| // A privately use function to set the executable RAM space to something invalid. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Fixes issue 6990. This uses a bit of templating to remove the duplicate code that is the CodeBlocks in each emitter headers. No actual functionality change in this.
|
LGTM, I'll wait a bit for Buildbot to complete and will merge unless someone has an objection in the next 5min. |
delroth
added a commit
that referenced
this pull request
Apr 9, 2014
Remove dumb CodeBlock duplication in the emitters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes issue 6990.
This uses a bit of templating to remove the duplicate code that is the CodeBlocks in each emitter headers.
No actual functionality change in this.