[ARM] Minor cleanup to lXX and stX. Fixes a bug. #257
Merged
+41
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue in lXX where if the instruction was an update instruction and was a register address offset that we would add garbage values to the writeback register. Does some minor cleanups as well which save a few instructions here and there.
Sonicadvance1
added a commit
to Sonicadvance1/dolphin
that referenced
this pull request
Apr 10, 2014
There are a few instructions in lXX that aren't currently fastmem capable due to using a register offset. This implements fastmem for those few instructions. Really I'll be changing how ARMv7 fastmem works in the future so this is really temporary code. Just don't know how long it'll stay. This relies on PR dolphin-emu#257
Sonicadvance1
added a commit
to Sonicadvance1/dolphin
that referenced
this pull request
Apr 10, 2014
There are a few instructions in lXX that aren't currently fastmem capable due to using a register offset. This implements fastmem for those few instructions. Really I'll be changing how ARMv7 fastmem works in the future so this is really temporary code. Just don't know how long it'll stay. This relies on PR dolphin-emu#257
|
I don't really understand the code, but LGTM for style and stuff. |
Sonicadvance1
added a commit
to Sonicadvance1/dolphin
that referenced
this pull request
Apr 10, 2014
There are a few instructions in lXX that aren't currently fastmem capable due to using a register offset. This implements fastmem for those few instructions. Really I'll be changing how ARMv7 fastmem works in the future so this is really temporary code. Just don't know how long it'll stay. This relies on PR dolphin-emu#257
Sonicadvance1
added a commit
to Sonicadvance1/dolphin
that referenced
this pull request
Apr 10, 2014
There are a few instructions in lXX that aren't currently fastmem capable due to using a register offset. This implements fastmem for those few instructions. Really I'll be changing how ARMv7 fastmem works in the future so this is really temporary code. Just don't know how long it'll stay. This relies on PR dolphin-emu#257
Sonicadvance1
added a commit
to Sonicadvance1/dolphin
that referenced
this pull request
Apr 10, 2014
There are a few instructions in lXX that aren't currently fastmem capable due to using a register offset. This implements fastmem for those few instructions. Really I'll be changing how ARMv7 fastmem works in the future so this is really temporary code. Just don't know how long it'll stay. This relies on PR dolphin-emu#257
Sonicadvance1
added a commit
to Sonicadvance1/dolphin
that referenced
this pull request
Apr 10, 2014
There are a few instructions in lXX that aren't currently fastmem capable due to using a register offset. This implements fastmem for those few instructions. Really I'll be changing how ARMv7 fastmem works in the future so this is really temporary code. Just don't know how long it'll stay. This relies on PR dolphin-emu#257
Sonicadvance1
added a commit
that referenced
this pull request
Apr 14, 2014
[ARM] Minor cleanup to lXX and stX. Fixes a bug.
Sonicadvance1
added a commit
to Sonicadvance1/dolphin
that referenced
this pull request
Apr 14, 2014
There are a few instructions in lXX that aren't currently fastmem capable due to using a register offset. This implements fastmem for those few instructions. Really I'll be changing how ARMv7 fastmem works in the future so this is really temporary code. Just don't know how long it'll stay. This relies on PR dolphin-emu#257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes an issue in lXX where if the instruction was an update instruction and was a register address offset that we would add garbage values to the
writeback register.
Does some minor cleanups as well which save a few instructions here and there.