New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to generate a file's MD5sum. #265
Conversation
| u8 Output[16]; | ||
| std::ostringstream OutputString; | ||
| #define READ_SIZE (8*1024*1024) | ||
| u8* Data = new u8[READ_SIZE]; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
All comments addressed. |
| @@ -15,6 +15,7 @@ | |||
| #include <string> | |||
| #include <type_traits> | |||
| #include <vector> | |||
| #include <polarssl/md5.h> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This wraps around polarssl's MD5sum capability. Spawned from the discussion in PR dolphin-emu#265. Also relies on PR dolphin-emu#265
| { | ||
| u8 output[16]; | ||
| std::string output_string; | ||
| #define READ_SIZE (8*1024*1024) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| std::string output_string; | ||
| #define READ_SIZE (8*1024*1024) | ||
| std::vector<u8> data(READ_SIZE); | ||
| size_t read_size; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I think the PR title and commit message use odd grammar, or am I missing something when reading "Add the ability to generate a files MD5sum."? |
|
s/files/file's |
|
LGTM, don't agree that the wrapper is needed at all. I feel this can be merged and then the wrapper can come after if needed/wanted. |
This adds the ability to generate a files MD5sum in the ISO properties. This uses polarssl to generate the MD5Sum.
Add the ability to generate a file's MD5sum.
* Update DriverDetails.h * Update VulkanContext.cpp
This adds the ability to generate a file's MD5sum in the ISO properties.
This uses polarssl to generate the MD5Sum.