Quick fix for an invalid iterator #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimimi085181
force-pushed
the
texturecache-iterator-fix
branch
from
64b414f
to
ec9a1fd
Compare
|
Is this normal in git? |
|
Leave me alone, stupid git and stable and whatnot |
mimimi085181
force-pushed
the
texturecache-iterator-fix
branch
from
ec9a1fd
to
829fc3d
Compare
|
@dolphin-emu-bot rebuild |
|
LGTM |
|
Now the question is what is the lifetime of textures_by_hash.end(); ? Is it safe to use it this way, or is this going to blow up eventually like the version before, just in a different situation? |
CrossVR
added a commit
that referenced
this pull request
Jun 24, 2015
Quick fix for an invalid iterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
textures_by_hash_iter was pointing to elements of textures_by_hash, but pointing to textures_by_address.end() instead of textures_by_hash.end() when it's not pointing to an element.