Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheatSearchTab: Check Core state instead of checking a memory pointer. #2673

Merged
merged 1 commit into from Jun 29, 2015

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Jun 28, 2015

Fixes issue 8714.

@AdmiralCurtiss
Copy link
Contributor

Should be changed a few lines down in FilterCheatSearchResults() too.

Frankly I'm more curious why the memory pointer doesn't get null'd after emulation ends but this probably works.

@CrossVR
Copy link
Contributor Author

CrossVR commented Jun 28, 2015

@AdmiralCurtiss I think that's the kind of behaviour no one should rely on, especially not for something as important as state checking.

@phire
Copy link
Member

phire commented Jun 28, 2015

I think you actually want Core::IsRunning()

Otherwise you will be unable to use Cheat Search while dolphin is paused, which is kind of necessary at times.

@CrossVR
Copy link
Contributor Author

CrossVR commented Jun 28, 2015

@phire Core::IsRunningAndStarted() checks if the CPU thread has started, it is unrelated to whether it is paused.

@CrossVR CrossVR added this to the Dolphin Release 5.0 milestone Jun 28, 2015
CrossVR added a commit that referenced this pull request Jun 29, 2015
CheatSearchTab: Check Core state instead of checking a memory pointer.
@CrossVR CrossVR merged commit 9a244f0 into dolphin-emu:stable Jun 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants