Linux: Add an evdev based controller backend, to replace SDL. #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not deleted, because it's the only option for some other operating systems such as FreeBSD or any other slightly exotic operating system someone might try and run dolphin on.
Dolphin uses threads, but never actually pulled them it. Normally some library we depend on would pull threads in, but there are potential builds that forget to pull in threads.
Unless explicitly requested.
|
Tested on two further controllers:
|
skidau
added a commit
that referenced
this pull request
Jul 3, 2015
Linux: Add an evdev based controller backend, to replace SDL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Same as #2675, but for stable.
We were just using a limited subset of SDL, which essentially amounted to a thin wrapper around the evdev interface (/dev/input/eventX) and was causing us some headaches, introducing extra bugs and adding limitations.
Rather than clean things up, it was much easier to just use the evdev backend directly, which is reasonably well documented and very sane.
All other major operating systems stopped using the SDL backend ages ago, choosing to implement their own plugins which directly accessed the interfaces which SDL was also wrapping on those operating systems. With linux being the last major OS of dolphin to use the sdl backend, all of it's cross-platform advantages were rendered pointless.
However, on some operating systems (like the various BSDs) SDL is about the only solution, so this PR doesn't go as far to completely remove SDL.
Fixes 7486, 8630 and potentially other bugs.
This PR has been tested with: