SWCommandProcessor: fix the CPReg structure fields #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This structure fields should match byte-to-byte the layout of MMIO registers: it is addressed using the MMIO reg address when doing a CP MMIO read. This was unfortunately not the case, causing CP reads to be mostly broken with the software renderer.
|
LGTM'd by @Parlane on IRC. |
delroth
added a commit
that referenced
this pull request
Feb 4, 2014
SWCommandProcessor: fix the CPReg structure fields
|
lgtm :) |
Techjar
pushed a commit
to Techjar/dolphin
that referenced
this pull request
Jan 30, 2022
Added No Clip for Metroid Prime 3 Corruption NTSC standalone version
rapito
pushed a commit
to project-lylat/dolphin
that referenced
this pull request
Jun 16, 2022
0.1.6 Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This structure fields should match byte-to-byte the layout of MMIO registers:
it is addressed using the MMIO reg address when doing a CP MMIO read. This was
unfortunately not the case, causing CP reads to be mostly broken with the
software renderer.