JitIL: fix carry computation for srawi. #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The carry computation needs to be based on the input value, not the output of the shift.
|
LGTM |
|
lgtm |
Sonicadvance1
added a commit
that referenced
this pull request
Apr 14, 2014
JitIL: fix carry computation for srawi.
Joern-P
pushed a commit
to Joern-P/dolphin
that referenced
this pull request
Mar 16, 2023
Show proper labels when GC controller is used on ports 1-4 in Wii mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The carry computation needs to be based on the input value, not the output of the shift.
Fixes http://code.google.com/p/dolphin-emu/issues/detail?id=1939, and a small homebrew test involving code like "int f(int a) { return a / 4; }".