PixelShaderGen: Color combiner compare mode fix and simplification #276
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plify the affected line a bit. This was a mistake of mine when translating floating point values to integer values. Also, the max() part of that line was just completely redundant because the sign of an absolute value is always greater than or equal to zero. Fixes issue 7178.
|
This is basically a nobrainer to merge, unless I messed up the number of closing brackets again... |
|
LGTM |
|
I tested it, you didn't mess up the brackets. LGTM. |
Parlane
added a commit
that referenced
this pull request
Apr 15, 2014
PixelShaderGen: Color combiner compare mode fix and simplification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Changed
int3(255,255,255)toint3(1,1,1)and removed the redundantmax().Fixes issue 7178.