WriteToConstRamAddress: support swap on 32 bit too #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
I also announce with this PR that this is the last JIT32 fix I'll commit. From now on, my changes will not support JIT32. Live with it or leave them unmerged. |
|
Also, this is an untested fix, waiting for JMC to test it. I don't have a 32 bit toolchain or operating system to test that. |
|
Now tested to be working. |
delroth
added a commit
that referenced
this pull request
Apr 21, 2014
WriteToConstRamAddress: support swap on 32 bit too
Joern-P
pushed a commit
to Joern-P/dolphin
that referenced
this pull request
Mar 16, 2023
Change some logging levels to debug to avoid huge spam in logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes issue 7195 (JIT32 being broken).