VideoCommon: Allow more Ram for HiresTexture if system memory is over 4GB #2874
Conversation
| size_t sys_mem = MemPhysical(); | ||
| size_t recommended_min_mem = 2 * (1024.0 * 1024.0); | ||
| // keep 2GB memory for system stability if system RAM is 4GB+ - use half of memory in other cases | ||
| size_t max_mem = (sys_mem - recommended_min_mem < recommended_min_mem) ? (sys_mem / 2) : (sys_mem - recommended_min_mem); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
You should rebase all the commits into a single one. |
|
You can ignore the FifoCI results, they give false positives sometimes. This PR's code looks nice to me now, but I'll let someone else weigh in on the policy of keeping 2 GB free. |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
It should be enough to not crash, so LGTM |
VideoCommon: Allow more Ram for HiresTexture if system memory is over 4GB
|
Do we want this in stable too? It's a simple change, and it's often requested by users. |
|
yeah, pick it :D |
Inspired by Jhonn on dolphin forum I created one improvement. IMO 2GB memory is enough to make sure that system will be stable.
This change will allow to have 6GB texture memory for users with 8GB RAM (previous 4GB).