Gameini updates. #290
Merged
Gameini updates. #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, even though I'd personally prefer if those per-game options where better commented wrt why specific overrides are necessary. |
|
I am thinking of making a pull request just for the explanation of settings. It might take a while to do though. |
|
If you're going to do write those explanation, please do it in this PR. There's no rush in merging this PR if it's not actually considered finished, yet. .. unless you are actually talking about making a PR for the explanation of settings in ALL game settings. |
|
It is the second and yes it will take a while, i don't think it is worth this pr to be on hold until then. |
|
ack. |
Updates game inis for Serious Sam: Next Encounter (gc), CAPCOM VS. SNK 2 EO (gc), Baten Kaitos Origins (gc), Baten Kaitos Eternal Wings and the Lost Ocean (gc), Sonic Adventure 2 Battle (gc), Sonic Riders (gc), Sonic Adventure DX (gc), Mini Ninjas (wii), The Legend of Zelda Skyward Sword (wii). Fixes issues 7146 and 6440.
For 007: Agent Under Fire (gc), SHADOW THE HEDGEHOG (gc), NFL Street (gc), NFL Street 2 (gc), NBA STREET V3 (gc). Fixes issues 7224, 7216 and 7238.
|
Have this pr got forgotten? I ended up making a second commit too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Updates game inis for Serious Sam: Next Encounter (gc), CAPCOM VS. SNK 2
EO (gc), Baten Kaitos Origins (gc), Baten Kaitos Eternal Wings and the
Lost Ocean (gc), Sonic Adventure 2 Battle (gc), Sonic Riders (gc), Sonic
Adventure DX (gc), Mini Ninjas (wii), The Legend of Zelda Skyward Sword
(wii).
Fixes issues 7146 and 6440.