Android: Allow finger movement while pressing button

[Hydr8gon]

Previously when pressing an on-screen button, as soon as your finger moved the slightest, the button would be released. This made it very hard to hold buttons down. With this patch, the button will stay pressed until you let go.

Resubmitted because the previous PR changed the permission of the file due to whatever I did to cause it.

[magumagu]

You can just force-push (push -f) on top of your branch if there's something wrong with it.

@dolphin-emu-bot rebuild

[lioncash]

Looks fine to me.

[delroth]

Wouldn't that set the button as pressed even if the movement did not start on that same button?

For example, swiping on all the buttons with this change would set all the buttons as pressed. Am I right?

[delroth]

I see. Not familiar with the Android code at all, sorry. Now that I've read
the whole method, it makes sense.

On Tue, Apr 22, 2014 at 3:49 AM, Sean notifications@github.com wrote:

@delroth https://github.com/delroth no. Example: you start by pressing
A, then swipe your finger over B. This /will/ activate B, but it will also
deactivate A.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/295#issuecomment-40996113
.

Pierre "delroth" Bourdon delroth@gmail.com
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/

[Hydr8gon]

@delroth Actually, you were right, which is why I deleted my comment. Fix incoming.

[lioncash]

I would add braces to the if and else statements. Especially with a comment of that size in the else case. IMO no brace if statements should only be used if only one line of code will sit after the if or else and nothing else. (sorry for the nitpick)

[Hydr8gon]

@lioncash Fine with me.

[lioncash]

err... sorry to be that guy again, but we use brace on the next line.

protip: You can roll back to the previous commit to do changes with git rebase -i <SHA ID of the commit before the one you want to make changes on>

ie)

Now say I want to roll back to "Some very minor cleanup to the logging window code", I hit the i key on my keyboard and change it to the following:

Then I hit escape and type :wq. This basically means "Write changes and quit".

Now we get:

There, we're successfully rolled back to that commit! So now you can make whatever changes you want to the source file you were working on, then do git add -u, and then git commit --amend then just type :wq again. Now the original commit is updated. So to roll back forwards again, just do git rebase --continue and it should bring you back to your current commit with the changes.

Then just push your changes with git push -f [your remote] [your branch name].

Just figured I'd tell you how to do this in case you didn't know.

[Hydr8gon]

@lioncash I'll get right on it. (Or not, my OS X terminal likes to glitch out for whatever reason)

[lioncash]

Nice, thanks :) Looks all good now.

[Sonicadvance1]

LGTM.
@dolphin-emu-bot rebuild