[Android] Fixes a bunch of input bugs. #300
Conversation
Sonicadvance1
changed the title
| if(!file.exists()) | ||
| final int CURRENT_VERSION = 1; | ||
| int ConfigVersion = Integer.decode(NativeLibrary.GetConfig("Dolphin.ini", "Android", "ConfigVersion", "0")); | ||
| if(ConfigVersion < CURRENT_VERSION) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Looking at the old code for the ButtonManager was a brainfsck. This fixes a ton of bugs I kept uncovering as I was moving along. Fixes the gamepad configuration file being incorrect. No longer treats touchscreen in a special way. Ends up as a regular device with a "Touchscreen" device name. Was incorrectly converting a index from integer to ButtonType. Wouldn't work due to the addition of some unused(in JNI) enumerators in ButtonType. Fixes an issue where a map had a key as an axis which was causing its binding to be overwritten for every axis that was used twice (eg main stick left and right); Fixes Triggers not working at all. Fixes DPad not working at all. Fixes C-Stick only half working. Removes touch screen specific nativelibrary types onTouchAxisEvent and onTouchEvent. Adds a configuration version configuration option. Allows easy configuration overwriting if the options need to be changed during updating. Supersedes github PR dolphin-emu#291.
|
Changed over to copying the GCPadNew configuration file every time. |
Uh, how do you plan to handle controllers connected to an Android phone? |
|
GCPadNew's configuration is a "virtual" device to be able to pull information ButtonManager and hav e touchscreen controls and gamepads merged in to one device. |
|
Herro, what is the deal with this old and crusty PR (which seems like it might be blocking further Android UI improvements)? |
|
It is kind of a pain to have this not merged yet, it's stopping me from finishing multitouch support because this commit will conflict with it, causing rebases one way or another. |
|
I don't know why this isn't merged I suppose. |
|
@Sonicadvance1 ok...? |
[Android] Fixes a bunch of input bugs.
Looking at the old code for the ButtonManager was a brainfsck. This fixes a ton of bugs I kept uncovering as I was moving along.
Fixes the gamepad configuration file being incorrect.
No longer treats touchscreen in a special way. Ends up as a regular device with a "Touchscreen" device name.
Was incorrectly converting a index from integer to ButtonType. Wouldn't work due to the addition of some unused(in JNI) enumerators in ButtonType.
Fixes an issue where a map had a key as an axis which was causing its binding to be overwritten for every axis that was used twice (eg main stick left and right);
Fixes Triggers not working at all.
Fixes DPad not working at all.
Fixes C-Stick only half working.
Removes touch screen specific nativelibrary types onTouchAxisEvent and onTouchEvent.
Adds a configuration version configuration option. Allows easy configuration overwriting if the options need to be changed during updating.
Supersedes github PR #291.