Add remaining possible uses of MOVBE

[Tilka]

Ceterum autem censeo x86-32 esse delendam.

[delroth]

LGTM if user testing does not find any weird bug. @JMC47

[Sonicadvance1]

I instantly get a Backpatch error with this.

[Tilka]

Fixed 32 bit, haven't looked into the Backpatch error yet.

[Tilka]

Fixed.

[Sonicadvance1]

Works for me and LGTM.

[delroth]

Will you be available in the next few days to fix crashes on a short notice?

If not, would appreciate some basic user testing from both people who have Haswell and people who have not. Leaving a forum thread for a day should probably be enough.

[Sonicadvance1]

I have tested a few games for a few minutes each and couldn't find a noticeable issue on my end for now.
Haswell CPU of course.

[comex]

So... backpatching assumes there are at least 5 bytes to replace with a call instruction. Usually the BSWAP was enough for this, but for 8-bit loads and stores two NOP bytes are added. However, some MOVBE instructions seem to be 4 bytes:

 0: 0f 38 f0 3f             movbe  (%rdi),%edi

Is this taken care of somewhere?

[Tilka]

@comex: No, but all our backpatched MOVBEs use memory references. Good catch though.

EDIT: OK, what I just said doesn't make any sense. I'll have a look.

[Tilka]

Should still be fine, we always have a SIB byte or an offset.

[Tilka]

Squashed.

[delroth]

Please try and monitor forums for issues that could be caused by this :)