Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize NOPs #304

Merged
merged 1 commit into from Apr 27, 2014
Merged

Optimize NOPs #304

merged 1 commit into from Apr 27, 2014
+55 −15

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Apr 23, 2014

No description provided.

@delroth
Copy link
Member

delroth commented Apr 23, 2014

I think this definitely needs some benchmarking.

Nah, LGTM.

(Though I'm interested in benchmark results on speed of NOPs :p)

@magcius
Copy link
Member

magcius commented Apr 23, 2014

why

@Sonicadvance1
Copy link
Contributor

Do we use NOP slides anywhere?

@Tilka
Copy link
Member Author

Tilka commented Apr 23, 2014

If we do they are not created with this function.

@Sonicadvance1
Copy link
Contributor

Any case, it is a todo that was long standing in the x86 emitter that is now fixed. LGTM

delroth added a commit that referenced this pull request Apr 27, 2014
@delroth
Merge pull request #304 from Tilka/nop
aef24d5 
Optimize NOPs
@delroth delroth merged commit aef24d5 into dolphin-emu:master Apr 27, 2014
@Tilka Tilka mentioned this pull request Apr 30, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@Tilka @delroth @magcius @Sonicadvance1