Workaround dumb custom texture loading logic. #307
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used on OS X) and GLES code paths have less broken custom textures.
|
We talked about this on IRC earlier. LGTM, does it fix the custom textures issues on D3D11? |
delroth
added a commit
that referenced
this pull request
Apr 23, 2014
Workaround dumb custom texture loading logic.
|
It does fix a lot of issues I came across. No idea if it fixes any of the issues people complained about. In my custom texture issue report thread people said they still had issues even with this patch, but I don't know if there is anything to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Basically, most (all?) non-RGBA32 textures failed to load on D3D (and other platforms which require all textures to be loaded as RGBA32) before. I have had this workaround lie around on my disk for ages now and I just can't get myself motivated to work on a proper fix.
Take this workaround or wait for someone to do a proper fix, but I'm done with the issue for now :p