Stereo3d presets #3076
Stereo3d presets #3076
Conversation
|
@dolphin-emu-bot rebuild |
| _trans("Use 3d Preset 1"), | ||
| _trans("Use 3d Preset 2"), | ||
| _trans("Use 3d Preset 3"), | ||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
void-ghost
force-pushed
the
stereo3d_presets
branch
from
f78972e
to
e45ca64
Compare
| std::string VideoBackend::GetConfigName() const | ||
| { | ||
| return "gfx_dx11"; | ||
| } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
It reduces redundancy. Needed make possible to save current video config.
void-ghost
force-pushed
the
stereo3d_presets
branch
from
e45ca64
to
18d7ab4
Compare
| @@ -51,6 +51,14 @@ enum StereoMode | |||
| STEREO_3DVISION | |||
| }; | |||
|
|
|||
| constexpr int STEREOSCOPY_PRESETS_NUM = 3; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
void-ghost
force-pushed
the
stereo3d_presets
branch
from
18d7ab4
to
404b45d
Compare
| @@ -84,6 +92,8 @@ struct VideoConfig final | |||
| int iStereoDepth; | |||
| int iStereoConvergence; | |||
| bool bStereoSwapEyes; | |||
| StereoscopyPreset oStereoPresets[STEREOSCOPY_PRESETS_NUM]; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…ereo-3d presets. Added 3 depth/convergence presets. They are adjustable via (existing) hotkeys - changes to depth and convergence are applied to current preset. Added 3 hotkeys for activating presets. Added hotkey for toggle between first and second preset. Added OSD message for convergence/depth changes. Presets are saved into per-game configs.
void-ghost
force-pushed
the
stereo3d_presets
branch
from
404b45d
to
7c1565b
Compare
|
LGTM |
|
Sorry, I'm just using this PR to test those random FifoCI failures @dolphin-emu-bot rebuild |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
How can I turn off this? [Video_Enhancements] |
|
Why isn't this commit reverted at least while the user works on fixed code? |
|
I would have made a revert PR myself, but, github says it cannot be automatically reverted or already was. |
PR dolphin-emu#3076 looks to be pretty poor quality and should be reverted.
Revert "Merge pull request #3076 from void-ghost/stereo3d_presets"
This adds customizable stereo-3d presets.
Added 3 depth/convergence presets. These are adjustable via (existing) hotkeys - changes to depth and convergence are applied to current preset.
Added 3 new hotkeys for activating presets and a hotkey for toggle between first and second preset.
Added OSD message to convergence/depth changes.
Presets are saved into per-game configs.
Changed depth/convergence hotkeys from "onHold" to "onPress" for more precise control.
Also added getter for video config filename (and removed repeated definitions for that filename). That was needed for first implementation, that saved presets into video config. This change is not needed by current implementation (but is good nonetheless, in my opinion).