Update mbed TLS (PolarSSL) #3091
Conversation
PolarSSL has been renamed to "mbed TLS" and version 2.0 dropped backwards compatibility. This commit adds only the necessary files without any modifications, so it doesn't compile yet.
They changed their license from GPLv2+ to Apache 2.0.
|
Connecting to Wiimmfi still works with this build. |
|
The "adapt Dolphin code" commit is the main commit that needs to be reviewed. |
|
I can't go online using this build, I keep getting 20100 error code. I tried with Wiimmfi, local altwfc and they both raise the error code 20100 when using this branch. When I use Dolphin 4.0-5378, it works normally. Altwfc didn't log a single connection attempt when I used this build which is very strange. Here is the debug log: |
|
Note: I was on Windows. Sorry for not specifying. |
|
@JMC47 EDIT: EDIT 2: What I did to get this issue: Then run it through visual studio 2015. EDIT 3: |
|
@Parlane any idea? |
|
@sepalani what is the output of |
|
@sepalani also change |
|
@shuffle2 Input: Output: État admin État Type Nom de l'interface
-------------------------------------------------------------------------
Activé Connecté Dédié Connexion réseau sans fil
Désactivé Déconnecté Dédié Connexion réseau sans fil 2
Désactivé Déconnecté Dédié Connexion réseau sans fil 3
Désactivé Déconnecté Dédié VMware Network Adapter VMnet1
Désactivé Déconnecté Dédié VirtualBox Host-Only Network
Désactivé Déconnecté Dédié VMware Network Adapter VMnet8
Désactivé Déconnecté Dédié Connexion réseau localHere is the new debug log from FormatMessageA (that looks like the same as before?): Otherwise, you can also try to freeze the game using netcat on port 443 (the game mustn't be SSL Stripped like Wiimmfi/Altwfc patched games i.e. unmodified games are fine): nc -l 443It will freeze the game when trying to connect to Nintendo servers. |
|
@sepalani so your log no longer has the |
|
@shuffle2 Concerning my compilation "bug", the latest working version I tested was : Dolphin Debug 4.0-7528. I tried several debug builds and the bug happens in Dolphin Debug 4.0-7538. So there is a change between those that breaks/changes something. I'm going to investigate this PR #2762 modifications. |
|
@sepalani please file a bug on bugs.dolphin-emu.org and we can talk about it there. seems unrelated to this commit. |
|
It seems with PolarSSL the socket is non-blocking by default which makes the read non-blocking. While for some reason in mbedTLS, the socket is now blocking the read (by default?). I assume EDIT: Alternatively I read, you could set non-blocking f_read/f_recv functions with |
|
@shuffle2 FYI, I was stringing random characters together until it compiled. |
|
Linus would be proud |
|
"make install" wants to install loads of mbedtls header files. See https://build.opensuse.org/package/live_build_log/home:KAMiKAZOW:Fedora/dolphin-emu/Fedora_22/x86_64 |
After PolarSSL was bought by ARM last year, they renamed it to "mbed TLS", changed the license from GPLv2+ to Apache 2.0, and released a new major version that broke backwards compatibility.
Definitely needs some testing.
Fixes issue 8976.