Small JIT optimizations #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are semantically equivalent and according to Agner Fog they can run on more execution ports than their floating point counterparts (at least on Intel CPUs).
|
ABI? |
|
I'm super disappointed that those easy paired instructions aren't implemented in JIT64IL. |
|
@delroth: You are right, ABI is the reason. None of the XMM registers are preserved across function calls but the lower ones are used to pass parameters. Dropped the allocation order commit. |
|
As discussed on IRC, let's wait a few days before merging that since we had a recent JIT related breakage. This will avoid confusion if this causes more bugs. |
|
@dolphin-emu-bot rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Any idea why we have this weird XMM register allocation order?