Mark which Wii root to use in the NAND path code #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested 8888 and 8720. Didn't test 8700, but I'm assuming if those two are fixed, the third is fixed as well. Bug 8888 - Export all Wii saves exports the saves successfully and verified that the files exist where the dialog popup tells me to go. |
| @@ -28,31 +29,31 @@ struct SNANDContent | |||
| u8* m_pData; | |||
| }; | |||
|
|
|||
| // pure virtual interface so just the NANDContentManager can create these files only | |||
| class INANDContentLoader | |||
| // this classes must be created by the CNANDContentManager | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
JosJuice
force-pushed
the
fix-wii-root
branch
from
a47acb3
to
f502001
Compare
It's used by both the GUI to do things like install WADs and check up on
the system menu, in which case the global root should be used, and by
/dev/es, in which case the local one should. The latter isn't
*terribly* useful today, since no contents will ever be installed in
temporary roots (although it's still relevant for data directories), but
converting the whole thing makes sense because then it will Just Work
once the entire NAND is synced.
Because it would have been a bit of work to split it up (but I can if
desired), this commit also contains some basic cleanup of
NANDContentLoader:
(1) The useless interface class INANDContentLoader is removed and the
methods are changed to just return CNANDContentLoader (the only
implementation);
(2) CNANDContentManager is changed to use unique_ptr and cleaned up a
bit.
JosJuice
force-pushed
the
fix-wii-root
branch
from
f502001
to
c22d1d6
Compare
Tilka
added a commit
that referenced
this pull request
Oct 16, 2015
Mark which Wii root to use in the NAND path code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is an updated version of PR #2642. Probably fixes all of these 5.0 blockers: https://bugs.dolphin-emu.org/issues/8888 https://bugs.dolphin-emu.org/issues/8720 https://bugs.dolphin-emu.org/issues/8700
@JMC47 Please test whether all three issues are fixed.