Use CRC32 for IPL checks and update hashes #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const u32 JAP_v1_1 = 0x46E899DB; | ||
| const u32 JAP_unknown = 0x87424396; | ||
| const u32 PAL_v1_0 = 0xAF912C43; | ||
| const u32 PAL_unknown = 0xA0EA7341; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ShadowsFriend
force-pushed
the
ipl_checksum
branch
from
54c656d
to
842da1d
Compare
|
Thanks for the feedback! I removed everything that was commented out and also added a cast from size_t to u32 to make the Windows buildbot happy. |
ShadowsFriend
force-pushed
the
ipl_checksum
branch
from
842da1d
to
d49e076
Compare
| const u32 JAP_v1_1 = 0xD235E3F9; // https://bugs.dolphin-emu.org/issues/8936 | ||
| const u32 PAL_v1_0 = 0x4F319F43; // Redump | ||
| const u32 PAL_v1_2 = 0xAD1B7F16; // Redump | ||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This changes the hashing algorithm from Adler32 to CRC32 for it is more widely used and therefore makes it easier to verify hashes. For example the Redump database does provide CRC32 hashes, while it doesn't have Adler32 ones. Additionally adds new hashes from the bugtracker and the forums and removes unknown ones.
ShadowsFriend
force-pushed
the
ipl_checksum
branch
from
d49e076
to
5fbf8f5
Compare
|
@dolphin-emu-bot rebuild |
|
Is there any reason for us not to merge this??? |
|
It looks good to me. |
Parlane
added a commit
that referenced
this pull request
Nov 20, 2015
Use CRC32 for IPL checks and update hashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This changes the hashing algorithm from Adler32 to CRC32 for it
is more widely used and therefore makes it easier to verify hashes.
For example the Redump database does provide CRC32 hashes, while it
doesn't have Adler32 ones.
Additionally adds new hashes from the bugtracker and the forums and
removes unknown ones.
Should fix issues https://bugs.dolphin-emu.org/issues/7035 and https://bugs.dolphin-emu.org/issues/8936.