Don't add segfault handler in interpreter mode

[Tilka]

...and use enum constants instead of plain numbers for referring to CPU backends.

[Tilka]

(Fixed build on non-x86.)

[Tilka]

Is there a nice way to fix the warning about "packet >> iCPUCore"?

(This is a serious problem, so don't merge this PR yet.)

[shuffle2]

@dolphin-emu-bot rebuild

[shuffle2]

@Tilka I'm not sure of a good way. Maybe specify the underlying type of the enum? Worst case, you could call the correct sf::Packet::operator>>(whatever) explicitly.

[Sonicadvance1]

Instead of having the startupparameter value for the CPU core be a enum object, couldn't we just have it be a u8 and compare it to the enums instead?
Kind of a bad programming practice though.
What if the enum was strongly typed? Might cause other issues though.

[shuffle2]

Oh, you can also specialize the operator implementation, which is probably the "proper" way to do it, although I'm not a huge fan. Something like http://stackoverflow.com/questions/1297609/overloading-friend-operator-for-template-class

[Tilka]

Changed to enum CPUBackend : u8 and rebased to current master.

[Tilka]

Ready to merge from my side.

[neobrain]

Apart from the things I pointed out, LGTM.

[Tilka]

Resolved merge conflict and addressed all remaining comments.

[neobrain]

@Tilka: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge.

---

@dolphin-emu-bot allowmerge

[Linktothepast]

I am getting a 10 to 20 % performance regression overall after this merge (tried DKC returns and Super Mario galaxy, DKC went from 72 fps to 55 fps in the overall map for example).

[neobrain]

Are you sure about this? As far as I can see, this branch doesn't change the behavior of JIT code at all.

[Linktothepast]

Yes i am pretty sure about this. Also it has another issue too, if i change the cpu engine, close and restart dolphin the cpu core will always be set to interpreter.

[Linktothepast]

Perhaps it uses jitil instead of jit or something? That might be an explanation of the performance regression.

[Tilka]

@Linktothepast Can't reproduce the config issue. Can you be more detailed? Did you start any games in-between?

[Linktothepast]

It is quite easy to reproduce, change the cpu engine to jitil and close dolphin (i didn't need to boot any games and by closing i mean the program altogether). Start dolphin again and see the default choice being set to interpreter instead.

[Tilka]

Never mind, I see the problem. (It's quite embarrassing lol.)