ogl: use a sample-able texture as EFB instead of renderbuffer #331
Conversation
|
Does that speed up EFB to Texture by not requiring a rendertarget switch? |
|
@delroth: It will speed up EFB2Tex with MSAA when we avoid the resolving. But this isn't implemented now. |
|
Please run a spell check over the comments. |
| if (m_msaaSamples <= 1) | ||
| { | ||
| // EFB targets will be textures in non-MSAA mode. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
updated |
|
@Sonicadvance1 do you know what's the issue with std::to_string on android? |
|
As evident by this stackoverflow question http://stackoverflow.com/questions/17950814/how-to-use-stdstoul-and-stdstoull-in-android |
|
Yep, I came across this problem a while ago when I tried to use newer C++11 string functions in the core as well. It's super fantastic that it's not documented anywhere (as far as I can tell), so people can actually know about this issue, and that the attitude of something not working was "lol lets just disable it" instead of actually fixing the underlying issue. |
Android has broken C99 support in it's NDK. This hasn't been too much of an issue since most uses of the disabled features have been in the WX GUI. This has become a bit more of an issue since we can't use std::to_string in common code due to it being disabled in basic_string.h due to the _GLIBCXX_USE_C99 define not being set. This StdBasicString header adds the disabled code block back in with the few functions removed that we can't use without C99. Once/If the Android NDK fully supports C99, this header can be removed. This PR is required for PR dolphin-emu#331 as it is trying to use to_string in Source/Core/VideoBackends/OGL/FramebufferManager.cpp
Android has broken C99 support in it's NDK. This hasn't been too much of an issue since most uses of the disabled features have been in the WX GUI. This has become a bit more of an issue since we can't use std::to_string in common code due to it being disabled in basic_string.h due to the _GLIBCXX_USE_C99 define not being set. This StdBasicString header adds the disabled code block back in with the few functions removed that we can't use without C99. Once/If the Android NDK fully supports C99, this header can be removed. This PR is required for PR dolphin-emu#331 as it is trying to use to_string in Source/Core/VideoBackends/OGL/FramebufferManager.cpp
Android has broken C99 support in it's NDK. This hasn't been too much of an issue since most uses of the disabled features have been in the WX GUI. This has become a bit more of an issue since we can't use std::to_string in common code due to it being disabled in basic_string.h due to the _GLIBCXX_USE_C99 define not being set. This StdBasicString header adds the disabled code block back in with the few functions removed that we can't use without C99. Once/If the Android NDK fully supports C99, this header can be removed. This PR is required for PR dolphin-emu#331 as it is trying to use to_string in Source/Core/VideoBackends/OGL/FramebufferManager.cpp
Android has broken C99 support in it's NDK. This hasn't been too much of an issue since most uses of the disabled features have been in the WX GUI. This has become a bit more of an issue since we can't use std::to_string in common code due to it being disabled in basic_string.h due to the _GLIBCXX_USE_C99 define not being set. This StdBasicString header adds the disabled code block back in with the few functions removed that we can't use without C99. Once/If the Android NDK fully supports C99, this header can be removed. This PR is required for PR dolphin-emu#331 as it is trying to use to_string in Source/Core/VideoBackends/OGL/FramebufferManager.cpp
| GLuint FramebufferManager::m_xfbFramebuffer; | ||
| GLuint FramebufferManager::m_efbColor; | ||
| GLuint FramebufferManager::m_efbDepth; | ||
| GLuint FramebufferManager::m_efbColorSwap; // for hot swap on reinterpret pixel format |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM once that last comment is fixed. Also, either squash your the suggested fixes into the original commits or change the commit message to something more descriptive than "Fix neobrain's suggestions" (which really is sort of useless when looking through git logs). |
|
Once the Android support gets merged in and this gets changed to handle it then it will LGTM. |
v2: Don't use std::to_string as this function is broken on android.
| { | ||
| // msaa without sample shading: calculate the mean value of the pixel | ||
| std::stringstream samples; | ||
| samples << m_msaaSamples; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
OpenGL: Use a sample-able texture as EFB instead of renderbuffer.
|
This change seems to cause severe slow down when users have 4x SSAA enabled. Maybe something to document in the GUI? https://forums.dolphin-emu.org/Thread-pr-331-causes-severe-slowdown-with-ssbb-4x-ssaa |
|
Please file a bug if this caused a regression. |
Renderbuffers are used to be faster for rendering, but on newer gpu generations, they internally doesn't care about renderbuffers vs textures any more. So there is no need for us to use renderbuffers which aren't as flexible as renderbuffers aren't usable as textures.
As example, interpretate format change emulation now directly sample the old msaa efb without resolving. This won't speed up (it's resolv vs sample shading), but we won't loose the MSAA sample information any more.
As CSAA is a legacy NV feature which is only compatible with renderbuffers, this feature is also removed. Also GLES3.0 doesn't support this kind of multisampled textures, but 3.1 does :D