XFB width/height handling fixes #336
Merged
+51
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this help Issue 7249 |
|
I can't tell what settings the reporter of issue 7249 was using, and I don't have the game, so I don't know. Are you offering to help test? :-) |
|
I was the reporter and i am willing to test |
|
Okay... I took another look at that issue report, and if I'm understanding it correctly, it's probably not related. We can continue the discussion in issue 7249. |
| @@ -316,6 +316,15 @@ union UVIDTVStatus | |||
| }; | |||
| }; | |||
|
|
|||
| union UVIHorizontalStepping { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM once the coding style issue and my other comment are addressed. |
What we call "fbWidth" here is really the stride, but I'll fix that in a followup.
We need to do this to correctly deal with games which dynamically change the XFB width and height.
Matching the hardware more closely will hopefully make this code easier to read.
|
Updated to address review comment. |
neobrain
added a commit
that referenced
this pull request
May 5, 2014
XFB width/height handling fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A couple fixes to help games which mess with the width/height of the XFB (in Real XFB mode). This doesn't implement horizontal scaling, so there will still be junk on the left side of the screen in games which use horizontal scaling, but this is a step in the right direction. Vertical scaling should work correctly, and games which displayed gibberish using RealXFB should at least display something recognizable.
(I'm still working on the horizontal scaling fix, but I want to make sure this part doesn't cause any regressions.)