Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: fix indirect texture coordinate computation in TEV. #344

Merged
merged 2 commits into from May 5, 2014

Conversation

magumagu
Copy link
Contributor

@magumagu magumagu commented May 5, 2014

Even if an indirect texture stage doesn't actually sample a texture, we
still need to emit the relevant math.

Fixes Issue 7092.

Even if an indirect texture stage doesn't actually sample a texture, we
still need to emit the relevant math.

Fixes Issue 7092.
…ctive.

This is consistent with the implementation in PixelShaderGen.
@Sonicadvance1
Copy link
Contributor

Tested this and it works pretty well.
LGTM

@JMC47
Copy link
Contributor

JMC47 commented May 5, 2014

Tested this with the GC and Wii VC NES games, all is good. Tested other games to look for potential regressions and fixes, but found nothing to be found. Seems to break nothing and fixes NES games.

neobrain added a commit that referenced this pull request May 5, 2014
VideoCommon: fix indirect texture coordinate computation in TEV.
@neobrain neobrain merged commit 4310608 into dolphin-emu:master May 5, 2014
@magumagu magumagu deleted the tev-indirect branch May 8, 2014 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants