TextureConversionShader: Also invert color encoders if they're used to encode depth. #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Please get a review from someone who understands our video code better than I do (degasus?) and feel free to merge. |
|
Confirmed to work. |
|
Yeah, sounds fine to me. |
|
LGTM |
CrossVR
added a commit
that referenced
this pull request
Jan 13, 2016
TextureConversionShader: Also invert color encoders if they're used to encode depth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The WriteC8Encoder and WriteC4Encoder are also used to encode depth buffers, but when D3D depth inversion was implemented I only accounted for the encoders that were only used for depth.
This fixes Metroid Prime 2 when using the depth visor to scan objects, issue 8925.