[Android] Implement support for real Wiimotes with the DolphinBar

[Sonicadvance1]

This is the only way to get Wiimotes working under Android now.
This, just like the Wii U Gamecube Controller Adapter, completely goes around Android's limitations and talks with the device directly through USBManager.

Couple notes.
Continuous scanning must be enabled otherwise the Wiimotes won't be seen.
The UI doesn't expose support for this yet. One must change the Wiimote source and continuous scanning settings manually.

Testing up to two wiimotes in Taiko No Tatsujin, no reason to believe all four won't work.

[JMC47]

I have no way to test this, but, does this affect non-Android at all?

[Sonicadvance1]

No.

[JMC47]

Then +1 from me

[lioncash]

Review status: 0 of 9 files reviewed at latest revision, 6 unresolved discussions.

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 18 [r1] (raw file):
Doesn't look like this is used outside of this source file (unless I've misread anything)

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 61 [r1] (raw file):
ampersands against type

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 69 [r1] (raw file):
static_cast

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 106 [r1] (raw file):
nullptr

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 148 [r1] (raw file):
nullptr

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 159 [r1] (raw file):
nullptr

---

Comments from the review on Reviewable.io

[Sonicadvance1]

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 18 [r1] (raw file):
You have misread. This variable isn't set inside of this source file.

---

Comments from the review on Reviewable.io

[Sonicadvance1]

Review status: 0 of 9 files reviewed at latest revision, 6 unresolved discussions.

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 61 [r1] (raw file):
Done.

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 69 [r1] (raw file):
Done.

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 106 [r1] (raw file):
Done.

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 148 [r1] (raw file):
Done.

---

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 159 [r1] (raw file):
Done.

---

Comments from the review on Reviewable.io

[degasus]

Review status: 0 of 9 files reviewed at latest revision, 1 unresolved discussion.

---

a discussion (no related file):

Continuous scanning must be enabled otherwise the Wiimotes won't be seen.
What about just enabling it by default on android?

---

Comments from the review on Reviewable.io

[Sonicadvance1]

That will be what is done.

On Fri, Feb 5, 2016 at 3:00 AM, Markus Wick notifications@github.com
wrote:

Review status: 0 of 9 files reviewed at latest revision, 1 unresolved

discussion.

a discussion
https://reviewable.io:443/reviews/dolphin-emu/dolphin/3593#-K9ke3wSo9o90DI3JWSJ:-K9ke3wSo9o90DI3JWSK:-657778840
(no related file):

Continuous scanning must be enabled otherwise the Wiimotes won't be seen.
What about just enabling it by default on android?

---

Comments from the review on Reviewable.io
https://reviewable.io:443/reviews/dolphin-emu/dolphin/3593

—
Reply to this email directly or view it on GitHub
#3593 (comment).

[Sonicadvance1]

Source/Core/Core/HW/WiimoteReal/IOAndroid.cpp, line 18 [r1] (raw file):
This global reference is going to get cleaned up along with the rest of the places in the source that does similar things in a couple of days.

---

Comments from the review on Reviewable.io

[BhaaLseN]

Reviewed 8 of 9 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

---

Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/Java_WiimoteAdapter.java, line 23 [r2] (raw file):
Any reason not to make those final aswell?

---

Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/Java_WiimoteAdapter.java, line 61 [r2] (raw file):
I'd put braces here, since the inside of the statement is not a single line

---

Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/Java_WiimoteAdapter.java, line 83 [r2] (raw file):
final?

---

Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/Java_WiimoteAdapter.java, line 91 [r2] (raw file):
Some space between the pipes?

---

Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/Java_WiimoteAdapter.java, line 114 [r2] (raw file):
Those two numbers appear multiple times throughout the code...maybe make them named constants too?

---

Comments from the review on Reviewable.io

[BhaaLseN]

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

---

Comments from the review on Reviewable.io