Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netplay Wii Remote Removal #3691

Merged
merged 1 commit into from Mar 4, 2016
Merged

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Mar 1, 2016

Finishes Helios' PR #3662, as it hasnt been touched in 10 days and I have fixed a segfault as well.

Fully removes wii remote netplay code from the UI, fixing a segfault when assigning controller ports that is currently present in master.

wiiremotenetplayremoval

Review on Reviewable

@JosJuice
Copy link
Member

JosJuice commented Mar 1, 2016

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.


Source/Core/DolphinWX/NetPlay/NetPlaySetupFrame.cpp, line 121 [r1] (raw file):
Capitalizing "cheats" looks odd.


Comments from the review on Reviewable.io

@Helios747
Copy link
Contributor

I forgot about that because I thought it was merged. Oops. >_> Sorry

Do you want me to close my PR?

@rukai
Copy link
Contributor Author

rukai commented Mar 2, 2016

Sure, if your happy with mine?


Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@Helios747
Copy link
Contributor

Yeah. I don't really care and this is less work for me. ;)

@RisingFog
Copy link
Member

Is the DSP Engine still required to match? If so, please add it in the message.

@rukai
Copy link
Contributor Author

rukai commented Mar 2, 2016

I asked JMC and he said there shouldn't be any settings to manually sync except, memory cards, SD cards and cheats.
I also tested netplay between HLE and LLE recompiler to make sure this wasn't an exception.


Comments from the review on Reviewable.io

@RisingFog
Copy link
Member

LGTM then.


Reviewed 3 of 4 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@JosJuice
Copy link
Member

JosJuice commented Mar 2, 2016

Should we note that the DSP ROMs need to be identical between players when DSP LLE is used?

@rukai
Copy link
Contributor Author

rukai commented Mar 2, 2016

Done.


Comments from the review on Reviewable.io

@Helios747
Copy link
Contributor

Can we get this merged soon? This fixes an oversight I had with my initial PR which can cause a crash. LGTM

@delroth delroth added this to the Dolphin Release 5.0 milestone Mar 4, 2016
delroth added a commit that referenced this pull request Mar 4, 2016
@delroth delroth merged commit 3b6af8c into dolphin-emu:master Mar 4, 2016
mimimi085181 added a commit to mimimi085181/dolphin that referenced this pull request Jun 26, 2016
mimimi085181 added a commit to mimimi085181/dolphin that referenced this pull request Jul 8, 2016
mimimi085181 added a commit to mimimi085181/dolphin that referenced this pull request Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants