New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netplay Wii Remote Removal #3691
Conversation
|
Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. Source/Core/DolphinWX/NetPlay/NetPlaySetupFrame.cpp, line 121 [r1] (raw file): Comments from the review on Reviewable.io |
|
I forgot about that because I thought it was merged. Oops. >_> Sorry Do you want me to close my PR? |
|
Sure, if your happy with mine? Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. Comments from the review on Reviewable.io |
|
Yeah. I don't really care and this is less work for me. ;) |
|
Is the DSP Engine still required to match? If so, please add it in the message. |
|
I asked JMC and he said there shouldn't be any settings to manually sync except, memory cards, SD cards and cheats. Comments from the review on Reviewable.io |
|
LGTM then. Reviewed 3 of 4 files at r1, 1 of 1 files at r2. Comments from the review on Reviewable.io |
|
Should we note that the DSP ROMs need to be identical between players when DSP LLE is used? |
|
Done. Comments from the review on Reviewable.io |
…teReal in NetPlayClient.cpp
|
Can we get this merged soon? This fixes an oversight I had with my initial PR which can cause a crash. LGTM |
Finishes Helios' PR #3662, as it hasnt been touched in 10 days and I have fixed a segfault as well.
Fully removes wii remote netplay code from the UI, fixing a segfault when assigning controller ports that is currently present in master.