Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften up some of the UI elements on Android #373

Merged
merged 3 commits into from Jun 20, 2014

Conversation

sigmabeta
Copy link
Contributor

A few tweaks to font sizes, weights, and colors to make the UI look less Gingerbread-ish. Also makes the touch targets for the items in the hamburger menu a little taller, so they are easier to touch.

These changes can be previewed here:

http://imgur.com/qwtBzlm
http://imgur.com/yZmH7ZQ

Those are images from the Android Studio UI editor, because I don't know how to build correctly for Android yet. The UI specific stuff builds fine though, so I doubt there will be a problem getting it to build.

Also, anything marked with the xmlns 'tools' won't show up at runtime, they are just placeholders for the UI editor.

@sigmabeta sigmabeta changed the title Soften up some of the UI elements. Soften up some of the UI elements on Android May 15, 2014
@@ -18,6 +21,9 @@
android:layout_width="fill_parent"
android:layout_height="26dip"

tools:text="File Size: 1459978240"

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@lioncash
Copy link
Member

I would say in the first image the text looks much too light. Especially the file size text. However, that's just my opinion.

@sigmabeta
Copy link
Contributor Author

The lighter text color is because Holo Light's default black-on-white text is too contrast-y. The filesize text field is not as important as the title, so it's even lighter to illustrate that relationship.

Stuff like that is all over Android 4.2+ish stuff, particularly the stuff from Google (for example http://imgur.com/tsbXAal)

I could pull it back and make the title a little darker if other people think it's too light, though

…view, and darken the game title text a little
@MayImilae
Copy link
Contributor

In the google reference image you provided, the text is a little bit bigger. If you are going to stick to these norms, you should make the game name font a little bigger to at least match it.

http://i.imgur.com/00LTS61.jpg

Also, on a side note, direct link your images please. It's annoying to click through on dialup.

@sigmabeta
Copy link
Contributor Author

I could bump up the size a little bit. I'm not sure it's good to make it quite as large as the heading font on those Now cards - on a phone in portrait mode, we would run out of screen space for longer titles pretty quickly.

I doubt that's a huge issue because the user could just flip the phone - or look at the banner icon.

Something like this perhaps?

dolphingamelistmockup2

That font size should fit most titles. The only title I have that's longer MP2E is TLOZ: Wind Waker. But again, if you don't recognize that from its banner...

Edit: Now that I step back and look at it, it seems that is approximately as large as the Now cards' heading font.

…size if text doesn't fit. Also set both text fields to a slightly lighter color.
@neobrain
Copy link
Member

@Sonicadvance1 Please decide whether we accept this patch or not.

Sonicadvance1 added a commit that referenced this pull request Jun 20, 2014
Soften up some of the UI elements on Android
@Sonicadvance1 Sonicadvance1 merged commit d62ae92 into dolphin-emu:master Jun 20, 2014
@Hydr8gon
Copy link
Member

I really don't like how this looks. I have a 4.5" screen @ 720p, and the titles are way too big. It may work on larger screens but I feel there are a lot of devices that this will look way too large on.

http://imgur.com/LmeWY1p

@sigmabeta sigmabeta deleted the android-ui-cleanup branch June 9, 2015 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants