D3D11: Fix EFB MSAA depth buffer copies, StateManager desyncs in some cases #3745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes EFB depth buffer copies when MSAA is enabled.
This was occuring in certain EFB copy patterns, leaving the textures unbound for the next draw call.
|
This pr fixes the Donkey Kong Returns issue that happens with dx11, at least it does with the fifo log, i don't have the game. I did not test the Metroid Prime 2 issue, because i could not reproduce the issue at the start of the game. |
|
This should get reviewed and merged. Fixes two blockers. |
|
I tested this again yesterday. Please review/merge. @delroth |
|
I have 0 knowledge about D3D. If someone reviews this code I'll be happy to merge it, otherwise I'd rather wait. |
|
Right. My bad. @Armada651 you're our only hope. |
|
LGTM. Whether you're outputting depth values as a render target or a depth-stencil target shouldn't matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pulling these commits from my other D3D11 PR.
Sorts out the issues with #3266 not working for D3D11.
Also fixes https://bugs.dolphin-emu.org/issues/8247, it's a minor change, EFB depth buffer copies with MSAA is broken (regression introduced by #3495), if I remember correctly.
This change is