Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove instant ARAM DMA hack (Fixes Sarge's War) #3771
Instant ARAM DMA is a blatant hack that only ever fixed things in RE2 and RE3. It activates for a lot of other games, but as far as I'm aware it doesn't fix any bugs. It just causes more bugs.
With scheduling fixes, it breaks ATV: Quad Power Racing 2 (causing all sorts of weird bugs) and stops Sarge's War from loading.
Maybe I could tweak the timings to get #3773 working for Sarge's War too, but the clean way is to just delete the horrendous hack. Now that Dolphin 5.0 has been released we can do this.
Unfortunately, this PR causes audio glitches in RE2 and RE3, but they never should have been working in the first place. Someone else can fix them correctly next time.
referenced this pull request
Apr 10, 2016
I would be more tempted to keep this hack around if:
Supposedly, the game is overwriting the audio data is being DMAed with zeros, before it gets DMAed out, and proper emulation of the L2 cache would fix this. However this doesn't seem to add up, the game gets fixed when you move the time the DMA completion interrupt arrives. Not when you move the actual copy (we always do the copy instantly).
Hopefully someone will find some more time and fix RE2/3 correctly later.