Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit netplay chat messages to 2000 characters. #393

Merged
merged 1 commit into from May 28, 2014

Conversation

RachelBryk
Copy link
Member

There's not really a good reason to be sending messages longer than that, and very long messages can hang dolphin for quite a long time.

@lioncash
Copy link
Member

This does what it says so I'm fine with this, but I do have a suggestion which can add on to this.

I'm not sure how the Netplay UI looks in terms of how the chatting is handled (never used netplay), but possibly a limit notifier can be added in some form. One that's like 0/2000 that counts up from the left-hand side and disallows adding more characters to the message once that limit is hit (ie. 2000/2000). Don't let this be a PR blocker though.

@RachelBryk
Copy link
Member Author

Hmm, i don't think there's really any good place to put that in the ui. Limiting the text box is probably a good idea though.

There's not really a good reason to be sending messages longer than that, and very long messages can hang dolphin for quite a long time.
@lioncash
Copy link
Member

Since the text box is capped at 2000 characters now, is the other check still necessary?

@delroth
Copy link
Member

delroth commented May 28, 2014

@lioncash never trust network input :)

delroth added a commit that referenced this pull request May 28, 2014
Limit netplay chat messages to 2000 characters.
@delroth delroth merged commit 21cf8fe into dolphin-emu:master May 28, 2014
@RachelBryk RachelBryk deleted the netplay-chat-limit branch July 6, 2014 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants