Gameini updates. #397
Gameini updates. #397
Conversation
|
@JMC47 @MaJoRoesch care to review that? |
|
Honestly looks pretty good. I reviewed the games I know that could use EFB2Texture, and it looks like the INIs got 'em. There may be some I'm missing since there are so many, but it seems good to me. Is that all the NES games in all regions? |
|
Most of them, just a few are missing, same for Master System. |
|
For Virtual Console NES games, scaled EFB copy being off no longer matters. They do need 1x IR though. |
|
I've set it to integral values since they seem to be working well. |
|
This is not true for most games. 3X IR kills graphics in Castlevania, for instance. |
|
Confirming what JMC is saying. EFBscale isn't a problem, but anything over 1x Native screws up most NES games, even integral values like 2x native. |
|
Scaled EFB copy on does cause problems in Zelda 1 at 2x IR, while turning it off does work for 2x IR at least. |
|
Yea well, just leave it on for that one then. shrug |
|
Guys can you post a screen shot of the difference? I tried castlevania 3x and it seems fine here. |
|
Absolutely, sorry for being lazy about it. 1x: https://dl.dropboxusercontent.com/u/484730/FEQE01-5.png Edit: It is known that NES games behave differently on NVIDIA and AMD graphics cards. I have NVIDIA. Also happens if you have Widescreen on, which I turned off 'cause eww stretching. |
|
Could it be an NTSC/PAL difference? |
|
I am not getting that issue jmc so we need to track it down a bit. Did you use a PAL version? What were the rest of your settings? Also do you guys have an AMD card? |
|
Of relevant settings: EFB Copies is to Ram, Texture Cache is safe, XFB disabled (needed for every game anyway,) no Anti-Aliasing, no Anistrophic Filtering, no other enhancements. No hacks enabled and nothing checked in General either. I do have an AMD card, but putting it into my computer is a bit of a hassle. FWIW, this also happen on my laptop. GTX 760 on my main box, GTX 560m on my Laptop. Both have intel processors, one is Windows, other is Linux. |
|
Right, i 've found it, seems an opengl issue, direct 3d works fine. So enforce 1x anyway to cover every case? |
|
I have a question: Does D3D work without issue for you? What graphics card are you running? I ask this because D3D does not work properly with Virtual Console games for me. Constant flickering/glitches. |
|
Yes it works just fine and i have a 560 ti with latest drivers. |
|
Okay, let me update drivers; the whole reason I haven't updated is due to the OGL crash. If I can confirm it's a driver issue and check it in my games, then I think letting scaled EFB on is fine. |
|
The more I think about it, there's literally no reason to up the IR in NES VC games, so, I'd actually rather have it forced to 1x IR. Considering OSX and Linux only have OGL, it may be a better idea. |
|
OK, we have a consensus then in enforcing 1xIR? |
|
I think it's fine. There's no noticeable benefit to upping the IR, right? If there is, maybe there'd be an argument against it, but I can't think of anything that would matter for old 2D games. |
|
It makes graphics sharper as if they passed from a sharpening filter. Nothing more i can think. |
|
On latest drivers I still can't get D3D to work. |
|
Enforcing 1x IR on NES games is fine with me. While higher IR is sharper, if it doesn't work it doesn't work, and the vast majority don't. |
Various changes.
Change Nes games efb scaling to 1x. Also fix issue 7314.
|
Ok it is done. I also fixed issue 7314 in the process. |
Updates for F-Zero X (n64), Yoshi's story (n64) and Curious George (gc). Fixes issue 7333.
|
I also fixed issue 7333 along with some small updates. |
|
I think we're all in agreement with this now? I think this is good to merge. |
|
Ahh, added the ZTP hack patch. JMC47 you've tested it, sure it should go in? |
|
Skid and I have tested it. It has to be manually enabled anyway. |
|
lgtm then. |
|
LGTM |
|
You can see the INIs that are affected by looking at the files changed by the commit. |
|
gameini - fix pal NES games get black Screen and garble mess. |
|
Stop posting on the github commits unrelated to your problem. Use OpenGL, EFB2RAM, and safe texture cache on NVIDIA cards. It's not Dolphin's bug! |
|
on osx (nvidia 320m) its on OpenGL, efb2ram & safe texture but the graphic is in a mess. |
|
That is driver problems, not the emulator. Now please stop posting on unrelated pulls. |
Addition of most Virtual Console NES and Master System games to the database.
Fixes issues 7311 and 7272.