Expand the Android app's about menu to include additional info about a user's device. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most fragments are not implemented yet. This is just a working base framework for it.
… simplify all interop with the EGL/GL APIs. Not hooked up yet. However it is entirely functional.
…display/hide it's fragment based upon this in AboutActivity.java. Also added another constructor to EGLHelper which can be used to quickly query for information.
…S3 tabs. There is a /lot/ of information in these tabs, we may have to think about changing how the information looks OpenGL isn't done yet since there are a million limits on desktop GL, may just show a few things and extensions there.
Since showing every single limit that desktop OGL supports is crazy, Let's just show the basic information, and extensions.
… list of cleaned up things: - Spaces -> Tabs | Consistency - Javadoc everything that was added and not documented. - Remove duplicated code regarding the adapter that used to reside in DolphinInfoFragment.java. Now it resides in AboutActivity.java without a second duplication of it. - Properly retrieve all of the contexts in the EGL initialization in EGLHelper.java. - Remove the attribute EGL_RENDERABLE_TYPE from the pbuffersurface attributes in EGLHelper.java. With this present, the EGL context will always fail to reinitialize if destroyed and attempted to be recreated. - Break the inner class Limit within GLES2InfoFragment.java, GLES3InfoFragment.java, and GLInfoFragment.java into its own single class. Greatly reduces code duplication. - Introduce a Type enum into Limit.java (one of the wildly rare cases in Java where an enum is actually an OK solution). Removes duplicated constants from the Java files stated in the previous bullet note. - Add a copyright comment to the top of EGLHelper.java. Forgot to do this initially, my bad. - Add some missing override annotations to GLES2InfoFragment.java, GLES3InfoFragment.java, and GLInfoFragment.java. - Use StringBuilders in the previously mentioned three Java files. This is better than using a String in this instance, as the String object won't have to be recreated multiple times (ala concatenation). - Fix some constant accessors in the previously mentioned three Java files. - Added the 'final' modifier to the above three classes and to Limit.java. These classes serve a single purpose only, and are not intended to be inherited.
….java. Not needed anymore since the introduction of the EGLHelper class. Also decouples some classes from the VideoSettingsFragment.java class (yay). - Minor other change is that the EGL helper fields in GLES3InfoFragment.java, GLES2InfoFragment.java, and GLInfoFragment.java are made final.
The info we retrieve will only ever have 2 elements given back to us.
ARM only at the moment. Could potentially support x86 and MIPS if necessary. Capable of parsing the manufacturer codes and part IDs of some (but not all part numbers). If anyone knows of part numbers that aren't in the list, please report them.
|
+1 Reviewed it in the last merge request. |
neobrain
added a commit
that referenced
this pull request
Jan 28, 2014
Expand the Android app's about menu to include additional info about a user's device.
delroth
referenced
this pull request
Jul 12, 2014
Make the emulation stop asynchronous to prevent deadlocks.
JeremyRand
pushed a commit
to JeremyRand/dolphin
that referenced
this pull request
Apr 1, 2015
update from original
OrN
added a commit
to OrN/dolphin
that referenced
this pull request
May 4, 2015
Merged
orbea
pushed a commit
to orbea/dolphin
that referenced
this pull request
Aug 25, 2017
Libretro android core wont compile with gcc, so force clang.
ghost
mentioned this pull request
FaultyPine
referenced
this pull request
in FaultyPine/dolphin
Jan 29, 2022
everything is happening when it should (i think). Just need to optimize savestates, handle random seeds, and fix a few edge cases
rapito
pushed a commit
to rapito/dolphin
that referenced
this pull request
Sep 16, 2022
Go from JSON to MessagePack
Sintendo
added a commit
to Sintendo/dolphin
that referenced
this pull request
Nov 2, 2022
ARM64's flexible shifting of input registers also allows us to calculate a negative power of two in one instruction; shift the input of a NEG instruction. Before: 0x128001f7 mov w23, #-0x10 0x1b1a7efa mul w26, w23, w26 0x93407f58 sxtw x24, w26 After: 0x4b1a13fa neg w26, w26, lsl dolphin-emu#4 0x93407f58 sxtw x24, w26
EndangeredNayla
pushed a commit
to EndangeredNayla/dolphin
that referenced
this pull request
Apr 5, 2023
Merge NO Squashing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.